Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring Oberon PSA core v1.2.1.1 #14136

Merged
merged 6 commits into from
Feb 28, 2024
Merged

Bring Oberon PSA core v1.2.1.1 #14136

merged 6 commits into from
Feb 28, 2024

Conversation

Vge0rge
Copy link
Contributor

@Vge0rge Vge0rge commented Feb 22, 2024 •
edited by stephen-nordic
Loading

Brings the new Oberon PSA core version 1.2.1.1 which includes the new standardized PAKE APIs.

Ref: NCSDK-26057

test-sdk-nrf: pake_api_alignment

@github-actions github-actions bot added manifest changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Feb 22, 2024
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Feb 22, 2024 •
edited
Loading

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
matter nrfconnect/sdk-connectedhomeip@b745cdf nrfconnect/sdk-connectedhomeip@efdae04 (master) nrfconnect/[email protected]
mbedtls nrfconnect/sdk-mbedtls@31eb94e nrfconnect/sdk-mbedtls@4625a60 (main) nrfconnect/[email protected]
zephyr nrfconnect/sdk-zephyr@ab0d6af nrfconnect/sdk-zephyr@0a1854b nrfconnect/[email protected]

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Feb 22, 2024 •
edited
Loading

Test specification

CI/Jenkins/NRF

  • Integration Platforms

CI/Jenkins/integration

Test Module File based changes Manually selected West overwrite
desktop52_verification X
test-fw-nrfconnect-ble X
test-fw-nrfconnect-ble_samples X
test-fw-nrfconnect-chip X
test-fw-nrfconnect-fem X
test-fw-nrfconnect-nfc X
test-fw-nrfconnect-nrf-iot_cloud X
test-fw-nrfconnect-nrf-iot_mosh X
test-fw-nrfconnect-nrf-iot_positioning X
test-fw-nrfconnect-nrf-iot_samples X
test-fw-nrfconnect-nrf-iot_thingy91 X
test-fw-nrfconnect-nrf-iot_zephyr_lwm2m X
test-fw-nrfconnect-nrf_crypto X
test-fw-nrfconnect-rpc X
test-fw-nrfconnect-rs X
test-fw-nrfconnect-tfm X
test-fw-nrfconnect-thread X
test-low-level X
test-sdk-audio X
test-sdk-find-my X
test-sdk-sidewalk X

test-fw-nrfconnect-chip: added because there was no .github/test-spec.yml in 'matter'
test-fw-nrfconnect-nrf_crypto: added because there was no .github/test-spec.yml in 'mbedtls'

Detailed information of selected test modules

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

vili-nordic
vili-nordic suggested changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@vili-nordic vili-nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also remove PSA_CRYPTO_SPAKE2P_USE_VERSION_04 in Kconfig

@Vge0rge
Copy link
Contributor Author

Vge0rge commented Feb 22, 2024

Can you also remove PSA_CRYPTO_SPAKE2P_USE_VERSION_04 in Kconfig

You are right of course, I removed it.

@github-actions github-actions bot added the doc-required PR must not be merged without tech writer approval. label Feb 23, 2024
@mswarowsky mswarowsky added this to the 2.6.0 milestone Feb 26, 2024
@Vge0rge Vge0rge force-pushed the oberon_new branch 2 times, most recently from 644de31 to 210e48e Compare February 26, 2024 16:17
@maciejbaczmanski maciejbaczmanski self-requested a review February 27, 2024 08:48
frkv
frkv approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@frkv frkv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

maciejbaczmanski
maciejbaczmanski approved these changes Feb 27, 2024
View reviewed changes
Copy link
Member

@maciejbaczmanski maciejbaczmanski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thread's side looks good: https://jenkins-ncs.nordicsemi.no/job/latest/job/night/job/test-fw-nrfconnect-thread/job/thread-test-branch/433/
One test failure is not connected with this PR

@Vge0rge Vge0rge removed the DNM label Feb 27, 2024
@Vge0rge Vge0rge removed the DNM label Feb 27, 2024
@jfischer-no
Copy link
Contributor

jfischer-no commented Feb 28, 2024 •
edited
Loading

@Vge0rge please rebase
Latest sdk-zephyr version probably comes with #14229

@hermabe hermabe mentioned this pull request Feb 28, 2024
Closed
jfischer-no
jfischer-no reviewed Feb 28, 2024
View reviewed changes
west.yml Outdated
@@ -61,7 +61,7 @@ manifest:
# https://developer.nordicsemi.com/nRF_Connect_SDK/doc/latest/zephyr/guides/modules.html
- name: zephyr
repo-path: sdk-zephyr
revision: f3f276dd2ecad981a2abf1d87c3d3d0b2e9d5373
revision: 76b0463a5a4b8b44cb4c82e5906711d18ae439db
Copy link
Contributor

@jfischer-no jfischer-no Feb 28, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0a1854bb2c1eba17490d1c82ba1f749a5745fc1e
nrfconnect/sdk-zephyr@0a1854b
nrfconnect/sdk-zephyr@7735bc6

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated, please merge.

Copy link
Contributor Author

@Vge0rge Vge0rge Feb 28, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jfischer-no If you want me to change the hash yet again you just edit the comment I don't any notification unfortunately. Please ping me if you want me to a a change.
But I will not update the hash actually. I will let the CI run and merge this. Another PR can update the hash. Since all the manifest PR is now blocked by this it makes more sense.

@jfischer-no jfischer-no mentioned this pull request Feb 28, 2024
Merged
Vge0rge and others added 6 commits February 28, 2024 11:44
@Vge0rge
ext: oberon: Bring Oberon PSA core v1.2.1.1
67f629e 
Bring Oberon PSA core version 1.2.1.1 which
includes the new standardized PAKE APIs.

Signed-off-by: Georgios Vasilakis <[email protected]>
Signed-off-by: Markus Swarowsky <[email protected]>
@Vge0rge
nrf_security: Adapt to Oberon PSA core v1.2.1.1
cd21b10 
Adapt nrf security to the new Oberon PSA core
v1.2.1.1.

Signed-off-by: Georgios Vasilakis <[email protected]>
Signed-off-by: Markus Swarowsky <[email protected]>
Signed-off-by: Frank Audun Kvamtrø <[email protected]>
@Vge0rge
manifest: Bring Zephyr changes for Oberon PSA core
542b723 
Bring required Zephyr changes for the new Oberon PSA core
v1.2.1.1

Signed-off-by: Georgios Vasilakis <[email protected]>
Signed-off-by: Markus Swarowsky <[email protected]>
@mswarowsky @Vge0rge
samples: ecjpake: Adapt to PSA crypto spec 1.2 PAKE APIs
83f429f 
Change to the final PAKE API's that are in the PSA crypto Spec 1.2 that
got introduced with oberon PSA core 1.2.1.1

Signed-off-by: Markus Swarowsky <[email protected]>
@mswarowsky @Vge0rge
manifest: mbedtls: Adapt to final PAKE APIs
1739cf5 
Change TLS to final PAKE APIs from PSA crypto spec 1.2

Signed-off-by: Markus Swarowsky <[email protected]>
@Vge0rge
manifest: Bring Matter with new PAKE APIs
f8d882a 
Brings Matter which uses the final PAKE APIs
from PSA crypto spec 1.2.

Signed-off-by: Georgios Vasilakis <[email protected]>
@stephen-nordic
Copy link
Contributor

The crypto test suite failure is unrelated to the changes here (crypto had passed in a previous run)

@stephen-nordic stephen-nordic self-requested a review February 28, 2024 12:00
@Vge0rge
Copy link
Contributor Author

Vge0rge commented Feb 28, 2024

We had other CI instabilities with IOT samples which I rerun and now they are green. Since I did that I also rerun Crypto and it is also green right now.

@rlubos rlubos merged commit b16fc5f into nrfconnect:main Feb 28, 2024
30 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mswarowsky mswarowsky mswarowsky approved these changes

@SebastianBoe SebastianBoe SebastianBoe approved these changes

@tejlmand tejlmand tejlmand approved these changes

@jfischer-no jfischer-no jfischer-no approved these changes

@frkv frkv frkv approved these changes

@mia-ko mia-ko mia-ko approved these changes

@ArekBalysNordic ArekBalysNordic ArekBalysNordic approved these changes

@vili-nordic vili-nordic vili-nordic approved these changes

@maciejbaczmanski maciejbaczmanski maciejbaczmanski approved these changes

@stephen-nordic stephen-nordic stephen-nordic approved these changes

@carlescufi carlescufi Awaiting requested review from carlescufi

@melwee01 melwee01 Awaiting requested review from melwee01

Assignees
No one assigned
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. CI-force-downstream doc-required PR must not be merged without tech writer approval. manifest manifest-matter manifest-mbedtls manifest-zephyr
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.